Fixes: #312 Add test cases for MaxEncodedSchemaLimitExceeded error#543
Open
Vaibhavsahu2810 wants to merge 2 commits intodhiway:develop_20250418from
Open
Conversation
Signed-off-by: Vaibhav <sahusv4527@gmail.com>
vatsa287
requested changes
Dec 23, 2024
| authorization_id.clone() | ||
| )); | ||
|
|
||
| assert!( |
Collaborator
There was a problem hiding this comment.
Use assert_err with the error code instead of manual assertion.
Contributor
Author
There was a problem hiding this comment.
Hello @vatsa287 ,when i am trying to use assert_err, panick get caused, the schema data can't even be converted to a BoundedVec because it exceeds the size limit, so we never get to the point of calling Schema::create
Contributor
Author
|
@vatsa287 what's your thought on this?? is there any other way to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
This PR adds a new unit test to the pallet-statement module to verify that the Schema::create function correctly handles schemas that exceed the maximum allowed encoded length.
The test covers the following scenarios:
Creates a schema with the maximum allowed encoded length.
Verifies that creating a schema with data exceeding the maximum length fails.
This test enhances the test coverage of the pallet-statement module and improves its robustness by ensuring that schema creation adheres to the defined size limits.