fix: Remove vc verify and implement new sdk#75
fix: Remove vc verify and implement new sdk#75Vikastc merged 11 commits intodhiway:cordproof-2025from
Conversation
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Vikastc
changed the title
Signed-off-by: vikastc <vikas.tc@dhiway.com>
|
you may need change in package.json to add newer cord sdk? |
|
Yes i have that in changes, will push . Just wanted to confirm 2 things in this pr-
|
Signed-off-by: vikastc <vikas.tc@dhiway.com>
|
that looks fine IMO. |
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Signed-off-by: vikastc <vikas.tc@dhiway.com>
| // Create new account with mnemonic | ||
| console.log('\n:bust_in_silhouette: Creating new account...'); | ||
| await cryptoWaitReady(); | ||
| const mnemonic = 'couple virtual next lottery state danger tent flame finger salad task material'; |
| } | ||
| }, 30000); | ||
|
|
||
| api.tx.balances |
There was a problem hiding this comment.
Can add a TODO to load the account with funds when stash account runs out of tokens.
It can be through a separate private service IMO.
There was a problem hiding this comment.
We can provide the faucet link
Signed-off-by: vikastc <vikas.tc@dhiway.com>
package.json
Outdated
| "author": "", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "@cord.network/vc-export": "0.9.6-alpha7", |
There was a problem hiding this comment.
| "@cord.network/vc-export": "0.9.6-alpha7", | |
| "@cord.network/vc-export": "0.9.6-alpha8", |
There was a problem hiding this comment.
Does this have type: 'sr25519'
There was a problem hiding this comment.
Yes your PR might be part of it. Check if the function is updated
There was a problem hiding this comment.
Tried it its not there
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Signed-off-by: vikastc <vikas.tc@dhiway.com>
| keyType: account.type, | ||
| signature: issuerAccount.sign(data), | ||
| keyType: issuerAccount.type, | ||
| keyUri: issuerDid, |
There was a problem hiding this comment.
can this change to issuerDid + '#' + issuerAccount.address ?
There was a problem hiding this comment.
You mean like this ?
keyUri: issuerDid + '#' + issuerAccount.address
If yes , why?
There was a problem hiding this comment.
yes. Because, issuerDid is going to give you a didDocument for verifying the signature / key.
But in this case, you are clearly telling which is the particular key out of the did you are using (note that there can be more than 1 key in a did, and you need to have data of that particular key in the keyUri field.
There was a problem hiding this comment.
Ok so will change the keyUri in both addProof() and updateAddProof()
Signed-off-by: vikastc <vikas.tc@dhiway.com>
3 participants
No description provided.