Merged
Conversation
Signed-off-by: vikastc <vikas.tc@dhiway.com>
amarts
reviewed
Sep 9, 2025
| return res.status(400).json({ | ||
| error: 'Registry not found for the provided address', | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
Can we take a default registry per org/key, and use the same for doc_hash call always? The same call can take registryId as optional field if required?
Contributor
Author
There was a problem hiding this comment.
It is allowing me to anchor one doc-hash per registry
Contributor
Author
There was a problem hiding this comment.
It is giving error if i try to use the same registry id more than once
amarts
approved these changes
Sep 9, 2025
Member
amarts
left a comment
amarts
left a comment
There was a problem hiding this comment.
LGTM - would prefer a common registry, instead of creating new everytime. Can be done as a followup too.
Signed-off-by: vikastc <vikas.tc@dhiway.com>
Signed-off-by: vikastc <vikas.tc@dhiway.com>
amarts
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if this is a correct implementation of doc-hash