Reading of genre from MP4 'gnre' atom#107
Open
earthrot wants to merge 3 commits intodhowden:masterfrom
Open
Conversation
Genre in MP4 files can be present either as ©gen (string) or gnre (uint8) mapping to the default ID3v1 list, 1-indexed.
Author
|
My bad, didn't see somebody else already has a pull request for this. |
Author
|
Having looked at the other request I'd like to reopen mine after all, hope this can get merged :) Also sorry for all the noise. |
dhowden
requested changes
Jul 25, 2024
Owner
dhowden
left a comment
dhowden
left a comment
There was a problem hiding this comment.
Might aswell go all the way and check the int type too :-P
Excellent idea! :) Co-authored-by: David Howden <dhowden@gmail.com>
dhowden
reviewed
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genre in MP4 files can be present either as ©gen (string) or gnre (uint8) mapping to the default ID3v1 list, 1-indexed.
p.s: first pull request of my life, please let me know if I messed up ❤️