-
Notifications
You must be signed in to change notification settings - Fork 377
feat(config): Add options to skip commit and push prompts #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(config): Add options to skip commit and push prompts #504
Conversation
hi @Sma1lboy please target your PR to dev branch |
got it, I'll do it tonight |
you need to merge dev into your branch manually |
23cbd04
to
4cc31a7
Compare
hi @di-sukharev di, I just manually merged it. |
@@ -86,7 +86,7 @@ ${commitMessage} | |||
${chalk.grey('——————————————————')}` | |||
); | |||
|
|||
const userAction = skipCommitConfirmation | |||
const userAction = skipCommitConfirmation || config.OCO_SKIP_COMMIT_CONFIRM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aint skipCommitConfirmation
does exactly what you also implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry for late response. You're right, but I really prefer to put it at the config level rather than using oco --yes every time, although I could create an alias in my shell environment. 🤔
From another perspective, I want to keep the config standard and make this content worthy of being managed through config for a unified trigger process.
This pull request introduces one new configuration options to streamline the commit workflow by skipping unnecessary confirmation steps.
I've been using these changes locally and they have significantly improved my workflow, allowing for faster commits with readable messages without the interruption of prompts. I believe this will be a valuable addition for many users who prefer a more automated process.
Changes:
OCO_SKIP_COMMIT_CONFIRM
: When set totrue
, this option skips the commit message confirmation prompt and automatically commits with the generated message. This is useful for users who trust the generated messages and want to speed up their workflow.These options can be configured via environment variables or the
opencommit
config file.Local Usage Log:
Here's an example of the streamlined workflow in action from my local environment:
I hope this pull request will be accepted. The constant prompting can be tedious, and this change provides a much-needed quality-of-life improvement for users who want a faster, more direct commit process.