Allows dash as last character in job name (#25)

Signed-off-by: joshvanl <[email protected]>

Author: JoshVanL

api.go

@@ -108,7 +108,8 @@ func validateName(name string) error {
 		return errors.New("job name cannot be empty")
 	}
 
-	for _, segment := range strings.Split(strings.ReplaceAll(strings.ToLower(name), "_", "-"), "||") {
+	trimmed := strings.TrimRight(strings.ReplaceAll(strings.ToLower(name), "_", "-"), "-")
+	for _, segment := range strings.Split(trimmed, "||") {
 		if errs := validation.IsDNS1123Subdomain(segment); len(errs) > 0 {
 			return fmt.Errorf("job name is invalid %q: %s", name, strings.Join(errs, ", "))
 		}

api_test.go

@@ -484,6 +484,10 @@ func Test_validateName(t *testing.T) {
 			name:   "foo.BAR_f-oo||foo",
 			expErr: false,
 		},
+		{
+			name:   "actorreminder||dapr-tests||dapr.internal.dapr-tests.perf-workflowsapp.workflow||24b3fbad-0db5-4e81-a272-71f6018a66a6||start-4NYDFil-",
+			expErr: false,
+		},
 	}
 
 	for _, test := range tests {