Failure Policy: Adds FailurePolicy API field to Job #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based of dapr/proposals#66 Adds a `FailurePolicy` option to the `Job` API to allow re-triggering job which are marked as failed by the caller. Adds two types of policy; `Drop` and `Constant`. `Drop` has no retry policy, `Constant` will constantly retry the job trigger for a configurable delay, up to a configurable maximum number of retries (which could be infinite). Note that the failure policy retry cadence has no effect on the actual Job schedule, meaning if a job was to be retired and eventually succeeded, the Job would continue to trigger at the origin configured schedule. By default, all Jobs will have a `Constant` policy with a delay of 1s. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
artursouza
reviewed
Oct 14, 2024
proto/api/failurepolicy.proto
Outdated
| // delay when the job fails to trigger. | ||
| message FailurePolicyConstant { | ||
| // delay is the constant delay to wait before retrying the job. | ||
| google.protobuf.Duration delay = 1; |
There was a problem hiding this comment.
Sounds good, I agree 👍
artursouza
suggested changes
Oct 14, 2024
Signed-off-by: joshvanl <[email protected]>
artursouza
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based of dapr/proposals#66
Adds a
FailurePolicyoption to theJobAPI to allow re-triggering job which are marked as failed by the caller. Adds two types of policy;DropandConstant.Drophas no retry policy,Constantwill constantly retry the job trigger for a configurable interval, up to a configurable maximum number of retries (which could be infinite).Note that the failure policy retry cadence has no effect on the actual Job schedule, meaning if a job was to be retired and eventually succeeded, the Job would continue to trigger at the origin configured schedule.
By default, all Jobs will have a
Constantpolicy with a interval of 1s.