Add spell-checking support with libspelling integration#420
Merged
rafaelmardojai merged 3 commits intomainfrom Jan 24, 2025
Merged
Add spell-checking support with libspelling integration#420rafaelmardojai merged 3 commits intomainfrom
rafaelmardojai merged 3 commits intomainfrom
Conversation
…ration Yes, it's needlessly complicated as is tradition :) Also fixes #399
rafaelmardojai
requested changes
Jan 23, 2025
rafaelmardojai
approved these changes
Jan 23, 2025
Member
rafaelmardojai
left a comment
rafaelmardojai
left a comment
There was a problem hiding this comment.
Everything works nice after testing.
Only problem I found is that our "detected" lang machinery sucks so you don't get spell cheking there, but same happens for TTS availability so we need to do a minor refactor there in general.
Also noticed that libspell doesn't "seamless" update the marked words when you change the lang, but that's not our issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes #399