feat(mode-directive, mode-island): DLT-3067 add v-dt-mode directive#1109
feat(mode-directive, mode-island): DLT-3067 add v-dt-mode directive#1109Francis Rupert (francisrupert) wants to merge 53 commits intonextfrom
v-dt-mode directive#1109Conversation
…SS foundation, deprecations, tooling, scratch page Dark theme tokens, radius-350, CSS :where() specificity softening, import ordering, watch tooling, inverted deprecations (link, text, breadcrumbs, keyboard-shortcut), input-group deprecation, deprecated badge in API table, scratch page.
…tion-deprecations-tooling
…nValue, and Page to dt-text component
…tive over DtModeIsland
…nd v-dt-mode directive
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3b7f19b0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "codex (@codex) address that feedback".
|
✔️ Deploy previews ready! |
|
I would add a |
Ignacio Ropolo (iropolo)
left a comment
There was a problem hiding this comment.
Looks good to me, and thanks for the laugh seeing the PR image!!
Add v-dt-mode directive
🛠️ Type Of Change
📖 Jira Ticket
DLT-3067
📖 Description
Bottom line
Before
After
Introduces the
v-dt-modedirective, a lightweight alternative toDtModeIslandthat applieslight,dark, orinverttheming directly to any element — no wrapper node required. The directive observes ancestor mode context and computes the opposite when usinginvert, reacting dynamically to app-level theme changes.Additional changes:
v-dt-modeinstead ofDtModeIslandvalidate-layersPostCSS plugindt-text,dt-link, anddt-button📦 Cross-Package Impact
dialtone-vuev-dt-modedirective; split-buttonalpha/omega→start/endrenamedialtone-cssvalidate-layersplugin improvement; button/table/mode-island Less changesdialtone-vuedepends on these stylesdialtone-tokensdialtone-documentationDependency flow: tokens → CSS → Vue → docs/MCP/language-server
📄 Documentation Artifacts
v-dt-modedirective added; split-button subcomponents renamedscripts/build-dialtone-vue-docs.mjsshould be run to pick up the new directive exportmode-island.md,split-button.md, and related pages updatedv-dt-modedirective not yet registered inpackages/dialtone-mcp-server/src/data.ts💡 Context
DtModeIslandwraps content in an extra DOM node just to setdata-dt-mode. Many real use cases already have a natural container (<section>,<nav>,<aside>), making the wrapper unnecessary. Thev-dt-modedirective eliminates this overhead while providing the same reactive theming — includinginvertmode which computes the opposite mode from context, reacting when ancestors change.📝 Checklist
For all PRs:
For all Vue changes:
For all CSS changes:
🔮 Next Steps
v-dt-modein MCP server dataDtModeIslandin favour ofv-dt-modedirective