feat(filter-pill): DLT-2941 DtFilterPill improvements#1110
feat(filter-pill): DLT-2941 DtFilterPill improvements#1110Francis Rupert (francisrupert) wants to merge 38 commits intonextfrom
Conversation
…SS foundation, deprecations, tooling, scratch page Dark theme tokens, radius-350, CSS :where() specificity softening, import ordering, watch tooling, inverted deprecations (link, text, breadcrumbs, keyboard-shortcut), input-group deprecation, deprecated badge in API table, scratch page.
…tion-deprecations-tooling
…wn modal behavior
…update list item focus styles
…on color override
|
Please add either the |
Francis Rupert (francisrupert)
added
the
no-visual-test
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Francis Rupert (francisrupert)
requested review from
Brad Paugh (braddialpad),
Ignacio Ropolo (iropolo) and
Nina Repetto (ninarepetto)
as code owners
|
✔️ Deploy previews ready! |
| &:focus-visible { | ||
| outline: none; | ||
| box-shadow: var(--dt-shadow-focus); | ||
| box-shadow: none; |
There was a problem hiding this comment.
No focus ring for list items? That's not accessible is it?
| @keydown.up.down.prevent="openPopover" | ||
| > | ||
| <template | ||
| v-if="$slots.startIcon" |
There was a problem hiding this comment.
do we need to use hasSlotContent() for these?
| /** | ||
| * When true, checkbox changes are held in a pending state until the user | ||
| * clicks Apply. Cancel or closing the popover discards pending changes. | ||
| * Only applies to popover mode (not useDropdown). | ||
| */ | ||
| deferSelection: { |
There was a problem hiding this comment.
Can we add a console.warn on mounted when this and useDropdown are set to true?
2 participants
🛠️ Type Of Change
📖 Jira Ticket
DLT-2941
📖 Description
label,filters,activeFilters,activeFilterList,activeFilterOverflow) for custom label patternsuseDropdownprop switching overlay from DtPopover to DtDropdown with single-select via DtListItem and arrow key navigationdeferSelectionprop holding checkbox changes in pending state until Apply; Cancel or closing discards changesreadOnlyprop suppressing chevron, clear button, and overlay; usesaria-disabledwith localized tooltip fallback📦 Cross-Package Impact
📝 Checklist
For all PRs:
For all Vue changes:
For all CSS changes:
filter-pill.mp4