chore(combobox-with-popover): DLT-2931 moved from recipe to component#1116
chore(combobox-with-popover): DLT-2931 moved from recipe to component#1116Ignacio Ropolo (iropolo) merged 16 commits intostagingfrom
Conversation
|
Please add either the |
Ignacio Ropolo (iropolo)
added
the
visual-test-ready
Ignacio Ropolo (iropolo)
requested review from
Brad Paugh (braddialpad),
Francis Rupert (francisrupert) and
Nina Repetto (ninarepetto)
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 539fffe4a2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| export default { | ||
| title: 'Recipes/Comboboxes/Combobox With Popover', | ||
| component: DtRecipeComboboxWithPopover, | ||
| title: 'Components/Combobox With Popover', |
There was a problem hiding this comment.
Changing the story title to Components/Combobox With Popover breaks the existing exclude match in packages/dialtone-vue/percy.config.cjs (Recipes/Comboboxes/Combobox With Popover: Empty), so the Empty story will start being snapshotted again even though it was explicitly excluded before. That can reintroduce noisy/flaky Percy runs unless the exclude entry is updated to the new title.
Useful? React with 👍 / 👎.
|
✔️ Deploy previews ready! |
2 participants
Moving combobox-with-popover from recipe to component
This go along with chore(combobox-multi-select): DLT-2930 moved from recipe to component
We keep
d-recipe-.