fix(editor): NO-JIRA empty div issue with nested block elements

[Maysam Kangarani Farahani (maysamkf)]

Empty div issue with nested block elements

Obligatory GIF (super important!)

🛠️ Type Of Change

These types will increment the version number on release:

• Fix
• Feature
• Performance Improvement
• Refactor

📖 NO-JIRA

📖 Description

• Added logic to not convert divs with block children into paragraphs

💡 Context

Nesting a block element in a div would cause it to render an extra newline (see SS below).
This is likely due to how Tiptap tries to flatten the html when parsing it.

📝 Checklist

For all PRs:

• I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
• I have reviewed my changes.
• I have added all relevant documentation.
• I have considered the performance impact of my change.

📷 Screenshots / GIFs

Observed Issue:

Fix:

[github-actions]

✔️ Deploy previews ready!
😎 Dialtone documentation preview: https://dialtone.dialpad.com/deploy-previews/pr-1121/
😎 Dialtone-vue preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-1121/

[Brad Paugh (braddialpad)]

This feels like a bit of a hack, is this not something that can be configured in TipTap/prosemirror itself?

If there's truly no other option we can go with it.

[Maysam Kangarani Farahani (maysamkf)]

This feels like a bit of a hack, is this not something that can be configured in TipTap/prosemirror itself?

If there's truly no other option we can go with it.

tried looking for other ways, but this seems to be the only way AFAIK.