Skip to content

Make the download pathlib= ValueError a warning #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndevenish merged 1 commit into from
Nov 5, 2025
Merged

Make the download pathlib= ValueError a warning #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dials_data/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import hashlib
import os
import tarfile
import warnings
import zipfile
from pathlib import Path
from typing import Any
Expand Down Expand Up @@ -309,9 +310,10 @@ def __call__(self, test_data: str, **kwargs):
if the dataset is not available.
"""
if "pathlib" in kwargs:
raise ValueError(
"The pathlib parameter has been removed. The "
"DataFetcher always returns pathlib.Path() objects now."
warnings.warn(
"pathlib argument is deprecated: Using Pathlib is now the default (and only) option.",
UserWarning,
stacklevel=2,
)
if test_data not in self._cache:
self._cache[test_data] = self._attempt_fetch(test_data)
Expand Down