Fix importing a DiceRoll with group rolls, modify test to cover#243
Open
aarku wants to merge 1 commit intodice-roller:developfrom
Open
Fix importing a DiceRoll with group rolls, modify test to cover#243aarku wants to merge 1 commit intodice-roller:developfrom
aarku wants to merge 1 commit intodice-roller:developfrom
Conversation
GreenImp
requested changes
Apr 11, 2022
|
|
||
| beforeEach(() => { | ||
| diceRoll = new DiceRoll('4d6/7+2d10dl1'); | ||
| diceRoll = new DiceRoll('{4d6/7+2d10dl1}'); |
Collaborator
There was a problem hiding this comment.
Would you mind reverting this, and creating a separate test for the roll group syntax?
Got to make sure that the other syntax still works, and that the group roll syntax works / throws the correct errors 😄
GreenImp
force-pushed
the
develop
branch
3 times, most recently
from
4ff7fb9 to
03379d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you export a
DiceRollwith roll groups, like with notation{d20}and then import the result, you will get an errorTypeError: value must be one of ResultGroup, RollResults, string, or number.This PR solves it by modifying
ResultGroup.addResultto accept a POJO, doing some very rudimentary validation, and instantiate the rich classes.Full JSON validation on import might be nice, but it would bloat the library. Perhaps it could be separated out into multiple packages, (Core, Import?) but that's quite an undertaking.
I also made a small repo that shows the bug: https://github.com/aarku/rpg-dice-roller-import-bug/blob/main/index.js
For testing, I decided to simply make the notation that gets exported/imported contain
{}.Hope it helps
-Jon