Skip to content

corrected use of build module. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougransom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

corrected use of build module. #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/building_natlink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ instructions below.

5. Install [Inno](https://jrsoftware.org/isdl.php) version 6.x. -
- Inno Setup compiler iscc.exe needs to be sys PATH.
6. Install flit to Python 3.10.x 32-bit interpreter `py -3.10-32 -m pip install flit`

6. Instally the pyproject-build command. This builds python modules in isolated enironments. A good idea to have on your system.
You can install pipx https://pipx.pypa.io/stable/installation/ (also a good idea) then `pipx installl build`. Or install build on any python on your system that will be in the path. You can even use natlink's 32 bit python if you want, though it unecessarily brings build into that environment.


### Building Natlink

Expand Down
4 changes: 3 additions & 1 deletion pythonsrc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ add_custom_command(
OUTPUT "${WHEEL_PATH}"
COMMENT "Building python wheel package in ${WHEEL_PATH}"
COMMAND ${CMAKE_COMMAND} -E copy ${NL_FILES} ${NL_PY_DIR}
COMMAND ${Python3_EXECUTABLE} -m build
#COMMAND ${Python3_EXECUTABLE} -m build
COMMAND pyproject-build

DEPENDS StampDriver # otherwise the stamps are not checked
${PROJECT_BINARY_DIR}/NatlinkSource/NatlinkSource.STAMP
${NL_FILES}
Expand Down