Merged
Conversation
added 7 commits
July 15, 2025 15:14
hiyuki
reviewed
Aug 4, 2025
| // 不需要转换 or 用户已定义回调，则不处理 | ||
| if (!promisifyFilter(key)) { | ||
| if (!promisifyFilter(key)) { | ||
| result[key] = function (...args) { |
Collaborator
There was a problem hiding this comment.
result[key] = listObj[key].bind(ENV_OBJ)
hiyuki
reviewed
Aug 4, 2025
| const originSuccess = obj.success | ||
| const originFail = obj.fail | ||
| if (originSuccess || originFail) { | ||
| warn(`The ${key} method has been promisified, please do not use success or fail callback. If you are certain that you want to handle the callback with options, please set usePromise to true. `) |
Collaborator
There was a problem hiding this comment.
The [${key}] method has been promisified, please use .then or .catch to handle the result, if you need to handle the result with options.success/fail, please set options.usePromise to false to close the promisify in this call temporarily.
hiyuki
reviewed
Aug 4, 2025
| } else { | ||
| result[key] = function (...args) { | ||
| const obj = args[0] || {} | ||
| const { usePromise = true } = obj |
hiyuki
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.