样式相关优化 #2375
Merged
样式相关优化 #2375
+98
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-un-translate-y))
hiyuki
reviewed
Jan 6, 2026
| return { prop, value: values[0].trim() } | ||
| } | ||
|
|
||
| const formatZIndex = ({ prop, value, selector }, { mode }) => { |
hiyuki
reviewed
Jan 6, 2026
| function calcVisitor ({ key, value, keyPath }: VisitorArg) { | ||
| if (calcUseRegExp.test(value)) { | ||
| // calc translate & border-radius 的百分比计算 | ||
| if (hasOwn(selfPercentRule, key) && /%/.test(value)) { |
hiyuki
reviewed
Jan 6, 2026
| // transform z-index auto to 0 | ||
| transformZIndex(normalStyle) | ||
| if (Array.isArray(normalStyle.transform)) { | ||
| normalStyle.transform = normalStyle.transform.filter(item => !isEmptyObject(item)) |
hiyuki
reviewed
Jan 6, 2026
| }, '') | ||
| } | ||
|
|
||
| function transformZIndex (styleObj: Record<string, any>) { |
Collaborator
There was a problem hiding this comment.
没必要加这个吧，如果这玩意需要运行时校验那要加的可太多了。。。
hiyuki
reviewed
Jan 12, 2026
| [ValueType.enum]: `${SUPPORTED_PROP_VAL_ARR[prop]?.join(',')}` | ||
| } | ||
| tips(`Value of ${prop} in ${selector} should be ${type}, eg ${info[type]}, received [${value}], please check again!`) | ||
| tips(`Value of ${prop} in ${selector} should be ${type}${info[type] ? `, eg ${info[type]}` : ''}, received [${value}], please check again!`) |
Collaborator
There was a problem hiding this comment.
类型校验细化一点吧，之前的定义的那个number应该叫length，对于z-index这种只允许纯数字的叫integer
hiyuki
reviewed
Jan 12, 2026
| function calcVisitor ({ key, value, keyPath }: VisitorArg) { | ||
| if (calcUseRegExp.test(value)) { | ||
| // calc translate & border-radius 的百分比计算 | ||
| if (hasOwn(selfPercentRule, key) && /calc\(\d+%/.test(value)) { |
hiyuki
reviewed
Jan 12, 2026
| borderTopRightRadius: 'width', | ||
| borderRadius: 'width' | ||
| } | ||
| const selfPercentRule: Record<string, 'height' | 'width'> = Object.assign({ |
hiyuki
reviewed
Jan 12, 2026
| parentFontSize?: number | ||
| parentWidth?: number | ||
| parentHeight?: number | ||
| isTransformBorderRadiusPercent?: boolean |
Collaborator
There was a problem hiding this comment.
简化一下：transformRadiusPercent
hiyuki
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.z-index auto 报错编译提示
2.样式编译优化：es6语法+__formatValue简化
3.去掉 translate & border-radius 的百分比计算 & 保留 translateY calc(100% - 20px)的百分比计算
4.去掉非媒体查询场景下的_default&_media字段
5.image 组件Android下保持计算border radius 百分比
回撤改动：
支持transform 分开定义 css var 且包含未定义值的var变量，如 --un-translate-x: -50%;transform translateX(var(--un-translate-x)) translateY(var(--un-translate-y));