Replace react-numeric-input package
#253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily replaces the
react-numeric-inputpackage because it uses outdated lifecycles that's no good for upgrading to React 18 and the package is unmaintained:Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.The approach taken in this PR is to remove the package and build the needed features directly into Typey Type.
There are some slight differences:
<b>with<button>elementsaria-label="Increment"1as1.0in theDiagram sizefield (it now shows1,1.1, etc)This PR also bundles in some other changes:
prompts.tests.ts