Tweak eslint rules #261
Merged
Tweak eslint rules #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Howler.stop() on global window object
Removing the number annotation causes other type errors that I don't want to deal with yet
The click handler exists here so that people may rage click it to make it go away, but there's also an actually accessible control in the UserSettings panel
- Remove large/small variants from markup and have only one image - Add toggle button semantics to play/pause the GIF - Simplify the positioning and responsive web behaviour using flex - Add support for Enter/Space to play/pause the GIF - Always show the static image when user prefers reduced motion
npx react-codemod update-react-imports No longer necessary because tsconfig.json has "jsx": "react-jsx"
We can use this again now that we've removed all the unused React imports using the codemod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
"eslint-config-react-app"with individual eslint plugins and makes related changes. It alsomapBriefToKoreanModernCStenoKeys.tsno-prototype-builtins// eslint-disable-next-linefor various rules in order to set up the configReactimports now thattsconfig.jsonuses"jsx": "react-jsx"debugger;anywithUserSettings"eslint-plugin-react-refresh"