Skip to content

Conversation

@ff137
Copy link
Collaborator

@ff137 ff137 commented May 7, 2025

Gets rid of "type" specifier for Proof/Presentation requests (Closes #1501)
We now infer type from anoncreds_ or ld_ fields being passed. Much simpler.

Indy models have also been removed, and replaced with AnonCreds or generic models where appropriate.


image

@ff137 ff137 changed the title 🚧 🔥 Remove Indy 🚧 🔥 Remove Indy proof type May 7, 2025
@didx-devops
Copy link
Contributor

didx-devops bot commented May 7, 2025

✅ All OpenAPI Specifications are in sync

No differences were detected in the OpenAPI specifications.

@ff137 ff137 changed the title 🚧 🔥 Remove Indy proof type 💥 Remove Indy proof type and models May 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2025

@ff137 ff137 self-assigned this May 8, 2025
@ff137 ff137 added improvement improving on something that is already existing (not a new feature as such) refactor labels May 8, 2025
@ff137 ff137 marked this pull request as ready for review May 8, 2025 11:08
@ff137 ff137 requested a review from cl0ete May 8, 2025 11:08
@github-actions
Copy link

github-actions bot commented May 8, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py60198%52
   verifier.py80495%32, 55, 85, 108
app/routes
   connections.py84199%198
   issuer.py117199%173
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/issuer
   acapy_issuer_v2.py98199%123
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/services/verifier
   acapy_verifier_v2.py131398%50, 96, 143
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   credential_exchange.py671184%67–73, 76–78, 82
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL532640892% 

Tests Skipped Failures Errors Time
990 7 💤 0 ❌ 0 🔥 6m 45s ⏱️

@github-actions
Copy link

github-actions bot commented May 8, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py60198%52
   verifier.py80495%32, 55, 85, 108
app/routes
   connections.py84199%198
   issuer.py117199%173
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/issuer
   acapy_issuer_v2.py98199%123
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/services/verifier
   acapy_verifier_v2.py131398%50, 96, 143
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   credential_exchange.py671184%67–73, 76–78, 82
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL532641292% 

Tests Skipped Failures Errors Time
990 40 💤 0 ❌ 0 🔥 4m 29s ⏱️

Copy link
Collaborator

@cl0ete cl0ete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GGWP!

@ff137 ff137 merged commit 83a26b9 into master May 8, 2025
87 of 91 checks passed
@ff137 ff137 deleted the remove-indy branch May 8, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement improving on something that is already existing (not a new feature as such) refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎨 Remove "type" field from credential and proof request bodies

3 participants