fix: falsy bookmark prop values rendering #3142
Merged
+67
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvHaus
commented
Apr 5, 2025
| const result = resolveBookmarks(root); | ||
|
|
||
| expect(result).toEqual(root); | ||
| expect(result).toEqual({ |
Contributor
Author
There was a problem hiding this comment.
Unrelated to the fix, but updated this test to test against a new variable instance. The previous test would always pass because the original root variable would get mutated.
diegomura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduced a regression where a
nullorundefinedvalue for thebookmarkprops would be rendered like thisinstead of being skipped. This PR fixes that and introduced a test to catch that.