Skip to content

fix: change the widthMatch typechecking method in borders resolve hel… #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeviousM wants to merge 6 commits into
base: master
Choose a base branch
from
+10 −2
Open

fix: change the widthMatch typechecking method in borders resolve hel… #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab800fa
fix: change the widthMatch typechecking method in borders resolve hel…
DeviousM Apr 7, 2025
0be06c0
Create famous-hounds-dream.md
DeviousM Apr 7, 2025
2971649
Update famous-hounds-dream.md
DeviousM Apr 7, 2025
c34c4fe
fix: set a default for styleMatch, in case of the "shorthand" value b…
DeviousM Apr 7, 2025
093ad49
Merge branch 'fix/fix-resolveBorderShorthand-width-resolving' of gith…
DeviousM Apr 7, 2025
e7517cb
Merge branch 'diegomura:master' into fix/fix-resolveBorderShorthand-w…
DeviousM Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-hounds-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-pdf/stylesheet": patch
---

fix: change the widthMatch typechecking method in borders resolve helper.
7 changes: 5 additions & 2 deletions packages/stylesheet/src/resolve/borders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,15 @@ const resolveBorderShorthand = <K extends BorderKey>(

if (match) {
const widthMatch = match[1] || value;
const styleMatch = match[4] || value;
const styleMatch = match[4] || value || 'solid';
const colorMatch = match[5] || value;

const style = styleMatch as BorderStyleValue;
const color = colorMatch ? transformColor(colorMatch as string) : undefined;
const width = widthMatch ? transformUnit(container, widthMatch) : undefined;
const width =
typeof widthMatch !== 'undefined'
? transformUnit(container, widthMatch)
: undefined;

if (key.match(/(Top|Right|Bottom|Left)$/)) {
return {
Expand Down