Skip to content

Support Rails 7.2 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Support Rails 7.2 #142

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a321ffd
Support Rails 7.2
mohammed-io Sep 26, 2024
44b5509
Updated Rails version matrix
mohammed-io Sep 26, 2024
54e2f3d
Bumped ruby version requirement to 3.0.0
mohammed-io Sep 26, 2024
d771147
Rubocop Ruby target as well
mohammed-io Sep 26, 2024
e5d7c69
remove redundant sort
mohammed-io Sep 26, 2024
e78e942
Update Rakefile
swiknaba Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
AllCops:
NewCops: enable
TargetRubyVersion: 2.6
TargetRubyVersion: 3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TargetRubyVersion: 3.0
TargetRubyVersion: 2.6


Style/ClassAndModuleChildren:
Exclude:
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ end
task default: :test

path = File.expand_path(__dir__)
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").sort.each { |f| load f }
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").each { |f| load f }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").each { |f| load f }
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").sort.each { |f| load f }

4 changes: 2 additions & 2 deletions diffcrypt.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.description = 'Diffable encrypted configuration files that can be safely committed into a git repository'
spec.homepage = 'https://github.com/diffcrypt/diffcrypt-ruby'
spec.license = 'MIT'
spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')
spec.required_ruby_version = Gem::Requirement.new('>= 3.0.0')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec.required_ruby_version = Gem::Requirement.new('>= 3.0.0')
spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')


# spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"

Expand All @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.executables = %w[diffcrypt]
spec.require_paths = ['lib']

spec.add_runtime_dependency 'activesupport', '>= 6.0', '< 7.2'
spec.add_runtime_dependency 'activesupport', '>= 6.0', '< 7.3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next version will be 8.0 tho.

spec.add_runtime_dependency 'thor', '>= 0.20', '< 2'
spec.metadata['rubygems_mfa_required'] = 'true'
end
7 changes: 4 additions & 3 deletions test/rails_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
require 'open3'

RAILS_VERSIONS = %w[
6.1.7.7
7.0.8.3
7.1.3.3
6.1.7.8
7.0.8.4
7.1.4
7.2.1
].freeze

RAILS_FLAGS = %w[
Expand Down
Loading