More rename.

ntwigg · ntwigg · commit dbdb7564d425 · 2025-09-04T11:17:16.000-07:00
diff --git a/browser-extension/src/datamodel/enhancer.ts b/browser-extension/src/datamodel/enhancer.ts
@@ -20,7 +20,7 @@ export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {
    */
   tryToEnhance(textarea: HTMLTextAreaElement): [OverType, Spot] | null
 
-  generateIcon(spot: Spot): string
-  generateDisplayTitle(spot: Spot): string
+  tableIcon(spot: Spot): string
+  tableTitle(spot: Spot): string
   buildUrl(spot: Spot): string
 }
diff --git a/browser-extension/src/datamodel/enhancers/github.ts b/browser-extension/src/datamodel/enhancers/github.ts
@@ -79,15 +79,15 @@ export class GitHubEnhancer implements CommentEnhancer<GitHubSpot> {
     return [overtype, spot]
   }
 
-  generateDisplayTitle(spot: GitHubSpot): string {
+  tableTitle(spot: GitHubSpot): string {
     const { slug, number } = spot
     if (number) {
       return `Comment on ${slug} #${number}`
     }
     return `New ${window.location.pathname.includes('/issues/') ? 'issue' : 'PR'} in ${slug}`
   }
 
-  generateIcon(spot: GitHubSpot): string {
+  tableIcon(spot: GitHubSpot): string {
     switch (spot.type) {
       case 'GH_ISSUE_NEW':
       case 'GH_ISSUE_ADD_COMMENT':

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export interface CommentEnhancer<Spot extends CommentSpot = CommentSpot> {`
`20`	`20`	`*/`
`21`	`21`	`tryToEnhance(textarea: HTMLTextAreaElement): [OverType, Spot] \| null`
`22`	`22`
`23`		`- generateIcon(spot: Spot): string`
`24`		`- generateDisplayTitle(spot: Spot): string`
	`23`	`+ tableIcon(spot: Spot): string`
	`24`	`+ tableTitle(spot: Spot): string`
`25`	`25`	`buildUrl(spot: Spot): string`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,15 +79,15 @@ export class GitHubEnhancer implements CommentEnhancer<GitHubSpot> {`
`79`	`79`	`return [overtype, spot]`
`80`	`80`	`}`
`81`	`81`
`82`		`- generateDisplayTitle(spot: GitHubSpot): string {`
	`82`	`+ tableTitle(spot: GitHubSpot): string {`
`83`	`83`	`const { slug, number } = spot`
`84`	`84`	`if (number) {`
`85`	`85`	return `Comment on ${slug} #${number}`
`86`	`86`	`}`
`87`	`87`	return `New ${window.location.pathname.includes('/issues/') ? 'issue' : 'PR'} in ${slug}`
`88`	`88`	`}`
`89`	`89`
`90`		`- generateIcon(spot: GitHubSpot): string {`
	`90`	`+ tableIcon(spot: GitHubSpot): string {`
`91`	`91`	`switch (spot.type) {`
`92`	`92`	`case 'GH_ISSUE_NEW':`
`93`	`93`	`case 'GH_ISSUE_ADD_COMMENT':`