Enhance editing comments in issues and PRs #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nedtwigg
added a commit
that referenced
this pull request
Sep 18, 2025
nedtwigg
force-pushed
the
feature/edit-comments
branch
from
519a014 to
d9f6798
Compare
nedtwigg
requested changes
Sep 18, 2025
Comment on lines
+252
to
+277
| "type": "GH_EDIT_COMMENT", | ||
| "unique_key": "github.com:diffplug/gitcasso:NaN", | ||
| }, | ||
| "title": "TITLE_TODO", | ||
| "upperDecoration": <React.Fragment> | ||
| <span | ||
| className="font-mono text-muted-foreground text-sm" | ||
| > | ||
| diffplug/gitcasso | ||
| </span> | ||
| <span | ||
| className="ml-2 font-medium" | ||
| > | ||
| PR # | ||
| NaN | ||
| </span> | ||
| </React.Fragment>, | ||
| }, | ||
| { | ||
| "for": "id=new_comment_field name=comment[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field overtype-input", | ||
| "spot": { | ||
| "domain": "github.com", | ||
| "number": 58, | ||
| "slug": "diffplug/gitcasso", | ||
| "title": "TODO_TITLE", | ||
| "type": "GH_PR_ADD_COMMENT", |
There was a problem hiding this comment.
for PRs, the first textarea is GH_EDIT_COMMENT and the second one is GH_PR_ADD_COMMENT. That is great!
Comment on lines
+188
to
+217
| "type": "GH_ISSUE_ADD_COMMENT", | ||
| "unique_key": "github.com:diffplug/gitcasso:56", | ||
| }, | ||
| "title": "TITLE_TODO", | ||
| "upperDecoration": <React.Fragment> | ||
| <span | ||
| className="flex h-4 w-4 flex-shrink-0 items-center justify-center" | ||
| > | ||
| <IssueOpenedIcon | ||
| size={16} | ||
| /> | ||
| </span> | ||
| # | ||
| 56 | ||
| <a | ||
| className="truncate hover:underline" | ||
| href="https://github.com/diffplug/gitcasso" | ||
| > | ||
| diffplug/gitcasso | ||
| </a> | ||
| </React.Fragment>, | ||
| }, | ||
| { | ||
| "for": "id=:ra7: name=null className=prc-Textarea-TextArea-13q4j overtype-input", | ||
| "spot": { | ||
| "domain": "github.com", | ||
| "number": 56, | ||
| "slug": "diffplug/gitcasso", | ||
| "title": "TODO_TITLE", | ||
| "type": "GH_ISSUE_ADD_COMMENT", |
There was a problem hiding this comment.
for issues, both the top and the bottom are identified as GH_ISSUE_ADD_COMMENT. That has to get fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.