Skip to content

Fix vcr #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 17 commits into from
Mar 4, 2025
Merged

Fix vcr #525

nedtwigg merged 17 commits into from
Mar 4, 2025

Conversation

@nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Mar 4, 2025

Fix a couple VCR bugs:

  • support multiple frames
  • support >= 10 frames
  • TODO: better debugging for mismatch in interactive mode

nedtwigg added 17 commits March 3, 2025 22:53
@nedtwigg
Adjust the sort order in ArrayMap to sort (1,2,...,9,10,11) instead o…
0000bf0 
…f (1,11,2,...).
@nedtwigg
Increment the index after each frame is taken.
819fa1e
@nedtwigg
Give VCR its own "msgSnapshotNotFound" message.
7dc03aa
@nedtwigg
Give an API to allow creating VCR selfie without a "TestLocator".
32c9797
@nedtwigg
Extract VcrSelfie's state into separate read and write for mutability…
33d8a76 
… control.
@nedtwigg
Make VcrSelfie concurrency safe.
623be54
@nedtwigg
Simplify unused parts of the ReentrantLock KMP interface.
2d04e25
@nedtwigg
Remove VcrSelfie.TestLocator
780912b
@nedtwigg
Pull the recordCall to where the other selfie types do it.
24f1432
@nedtwigg
Oops, broke the indices again.
d726d4f
@nedtwigg
Better error messages for VCR not finding comment.
8b9bcac
@nedtwigg
Fix boneheaded if.
78db66d
@nedtwigg
Turns out we need TestLocator still.
e0c7265
@nedtwigg
Big improvement to VCR error messages.
8aec163
@nedtwigg
Fix warnings.
b98b2ee
@nedtwigg
Remove RequiresOptIn.
2d97ea5
@nedtwigg
Update changelog.
35921b0
@nedtwigg nedtwigg marked this pull request as ready for review March 4, 2025 23:01
@nedtwigg nedtwigg merged commit a9f7f90 into main Mar 4, 2025
6 checks passed
@nedtwigg nedtwigg deleted the fix-vcr branch March 4, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nedtwigg