Skip to content

Conversation

@nathanregner
Copy link
Contributor

No description provided.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic contribution, thanks very much!

Can you update the changelog under ## Unreleased https://github.com/diffplug/selfie/blob/main/jvm/CHANGELOG.md. Maybe something like this:

### Fixed
- snapshots created by `junit.jupiter.api.TestFactory` are no longer garbage-collected (#534)
- support parallel testing under `junit.jupiter.execution.parallel.enabled=true` (#534)

I'll merge and release pronto.

@nathanregner
Copy link
Contributor Author

Fantastic contribution, thanks very much!

Can you update the changelog under ## Unreleased https://github.com/diffplug/selfie/blob/main/jvm/CHANGELOG.md. Maybe something like this:

### Fixed
- snapshots created by `junit.jupiter.api.TestFactory` are no longer garbage-collected (#534)
- support parallel testing under `junit.jupiter.execution.parallel.enabled=true` (#534)

I'll merge and release pronto.

Thank you for the fantastic library! Done!

@nathanregner nathanregner marked this pull request as ready for review May 20, 2025 23:27
@nedtwigg
Copy link
Member

For future reference, I prefer revisions to get pushed up as new commits rather than force-pushing over old ones. Easier to review just the incremental change rather than the whole thing over. Once it gets pushed up I'd rather the history be "honest" to the conversation from there rather than clean.

@nedtwigg nedtwigg merged commit 89b13e6 into diffplug:main May 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants