[prone] Apply UnnecessaryDefaultInEnumSwitch
#2702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pankraz76
commented
Oct 24, 2025
Pankraz76
commented
- https://errorprone.info/bugpattern/UnnecessaryDefaultInEnumSwitch
Pankraz76
commented
Oct 24, 2025
lib/src/main/java/com/diffplug/spotless/biome/BiomeExecutableDownloader.java
Show resolved
Hide resolved
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/GradleProvisioner.java
Show resolved
Hide resolved
|
|
||
| /** Returns the "canonical" form for this particular result (only possible if isResolvable). */ | ||
| public String canonical() { | ||
| // @formatter:off |
There was a problem hiding this comment.
i know it looks intended and i know you mentioned it recently, having done this (IDE) suggedtion already.
Can we evlevate this or do we need this form explizicly, then we could suppress these rare cases. Some of this pattern makes sense on some of the parts done.
Pankraz76
force-pushed
the
UnnecessaryDefaultInEnumSwitch
branch
from
1751960 to
2b70427
Compare
Pankraz76
force-pushed
the
UnnecessaryDefaultInEnumSwitch
branch
from
2b70427 to
0914367
Compare
nedtwigg
requested changes
Oct 27, 2025
| if (state.type == SPACE) { | ||
| builder.append(" ".repeat(numSpaces)); | ||
| } else if (state.type == TAB) { | ||
| builder.append("\t".repeat(Math.max(0, numSpaces / state.numSpacesPerTab))); |
There was a problem hiding this comment.
I don't see a need for the Math.max(0) part.
There was a problem hiding this comment.
yes thats off topic, as an ide suggestion:
Can be replaced with 'String.repeat()'
If we can replace a whole loop, with one single line of code its a good win reducing the overhead to a minimum:
Can we merge under this ciscumsstances, or should we undo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.