Open
Conversation
alaadotsol
requested changes
Aug 1, 2019
Member
alaadotsol
left a comment
alaadotsol
left a comment
There was a problem hiding this comment.
Seems good as a first version of the character plugin, good job!
Still, there are some stuff we should address, first of all make sure that the class's name is the same as the folder name.
Other points are going to be addressed in the plugins-roadmap discord channel before we can fully push it to master
tanukijs
reviewed
Aug 2, 2019
tanukijs
reviewed
Aug 2, 2019
tanukijs
requested changes
Aug 2, 2019
| mount(connections){ | ||
| this.connections = connections; | ||
| for(let username in connection){ | ||
| this.character[username] = new Character(username); |
Author
There was a problem hiding this comment.
yes typo it should be connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character plugin to manage characters: