forked from diggerhq/quickstart-actions-aws
-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor Terraform configuration and add S3 bucket #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jocelo
wants to merge
1
commit into
main
Choose a base branch
from
jocelo-aws-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed commented-out DynamoDB state locking configuration and several AWS resources including VPC, subnet, security group, and EC2 instance. Added a new S3 bucket resource with specific configurations.
plan for production-pce 2025-11-11 04:02:55 (UTC)Plan outputTerraform will perform the following actions:
# aws_s3_bucket.example_bucket will be created
+ resource "aws_s3_bucket" "example_bucket" {
+ acceleration_status = (known after apply)
+ acl = "private"
+ arn = (known after apply)
+ bucket = "unique-sample-bucket-terraform-111125"
+ bucket_domain_name = (known after apply)
+ bucket_prefix = (known after apply)
+ bucket_regional_domain_name = (known after apply)
+ force_destroy = false
+ hosted_zone_id = (known after apply)
+ id = (known after apply)
+ object_lock_enabled = (known after apply)
+ policy = (known after apply)
+ region = (known after apply)
+ request_payer = (known after apply)
+ tags = {
+ "Environment" = "Dev"
+ "Name" = "ExampleBucket"
}
+ tags_all = {
+ "Environment" = "Dev"
+ "Name" = "ExampleBucket"
}
+ website_domain = (known after apply)
+ website_endpoint = (known after apply)
}
Plan: 1 to add, 0 to change, 0 to destroy.
Warning: Argument is deprecated
with aws_s3_bucket.example_bucket,
on main.tf line 21, in resource "aws_s3_bucket" "example_bucket":
21: acl = "private"
Use the aws_s3_bucket_acl resource instead
(and one more similar warning elsewhere)
─────────────────────────────────────────────────────────────────────────────Terraform plan validation check (production-pce)Terraform plan validation checks succeeded ✅Plan summary
Instructionsdigger apply -p production-pce⏩ To apply all changes in this PR: digger apply🚮 To unlock all projects in this PR: digger unlock |
Author
|
digger apply |
apply for production-pce 2025-11-11 04:06:31 (UTC)Apply outputTerraform will perform the following actions:
# aws_s3_bucket.example_bucket will be created
+ resource "aws_s3_bucket" "example_bucket" {
+ acceleration_status = (known after apply)
+ acl = "private"
+ arn = (known after apply)
+ bucket = "unique-sample-bucket-terraform-111125"
+ bucket_domain_name = (known after apply)
+ bucket_prefix = (known after apply)
+ bucket_regional_domain_name = (known after apply)
+ force_destroy = false
+ hosted_zone_id = (known after apply)
+ id = (known after apply)
+ object_lock_enabled = (known after apply)
+ policy = (known after apply)
+ region = (known after apply)
+ request_payer = (known after apply)
+ tags = {
+ "Environment" = "Dev"
+ "Name" = "ExampleBucket"
}
+ tags_all = {
+ "Environment" = "Dev"
+ "Name" = "ExampleBucket"
}
+ website_domain = (known after apply)
+ website_endpoint = (known after apply)
}
Plan: 1 to add, 0 to change, 0 to destroy.
aws_s3_bucket.example_bucket: Creating...
aws_s3_bucket.example_bucket: Still creating... [10s elapsed]
aws_s3_bucket.example_bucket: Creation complete after 16s [id=unique-sample-bucket-terraform-111125]
Warning: Argument is deprecated
with aws_s3_bucket.example_bucket,
on main.tf line 21, in resource "aws_s3_bucket" "example_bucket":
21: acl = "private"
Use the aws_s3_bucket_acl resource instead
(and 2 more similar warnings elsewhere)
Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
|
Closed
Author
|
digger unlock |
|
✅ Command unlock completed successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed commented-out DynamoDB state locking configuration and several AWS resources including VPC, subnet, security group, and EC2 instance. Added a new S3 bucket resource with specific configurations.