-
Notifications
You must be signed in to change notification settings - Fork 561
Improvement/formatting setup #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improvement/formatting setup #2041
Conversation
This PR is too large to scan. |
You're absolutely right that this PR touches many files. However, since the changes are purely formatting-related (import organization and code style consistency), they shouldn't affect any functionality or cause test failures. The modifications are cosmetic in nature and maintain the same business logic throughout the codebase. |
Hello @motatoes, |
HI @Saurabh2402 thanks for this effort! However its very difficult for me to review this PR with so many lines changed. By the time I review it there would definitely be some merge conflicts in the repo, if you prefer you can have a PR with only the .golangci.yml changed and I can run the gofmt seperately so that that I can immediately merge it with no merge conflict, thanks!! |
Hi @motatoes , Thank you for the feedback! I completely understand your concern about the large diff making review difficult and potential merge conflicts. I appreciate you offering to run the formatting separately, but I'd love to find a solution where we can still capture the contribution properly in the git history because I spent considerable time setting up the comprehensive .golangci.yml configuration, testing it across the entire codebase, and ensuring all the formatting was applied correctly without breaking anything 🙂. Here are a couple of options that might work for both of us: Option 1: Split into smaller PRs
Option 2: Live collaboration call
I'm happy to go with whatever approach works best for you! What do you think would work best? Thanks again for maintaining this great project! 🙂 |
hey @Saurabh2402 I appreciate you but unfortunately that would be difficult. I'm keen to accept your contribution but to make this right for you I'm willing to accept the .golangci.yml file as a seperate file and I can run the formatting myself, let me know if it works for you! |
Changes Made
📄 New Configuration File
This is step 1 of implementing issue #2029, where I added the .golangci.yml configuration file