Merged
Conversation
Signed-off-by: Josef Andersson <josef.andersson@digg.se>
Signed-off-by: Josef Andersson <josef.andersson@digg.se>
janderssonse
force-pushed
the
feat/improve-just
branch
from
a87d87e to
4d66c86
Compare
Signed-off-by: Josef Andersson <josef.andersson@digg.se>
janderssonse
force-pushed
the
feat/improve-just
branch
from
cbfff37 to
d5efe91
Compare
janderssonse
commented
Oct 31, 2025
| <dependency> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-annotations</artifactId> | ||
| <version>4.8.6</version> |
Contributor
Author
There was a problem hiding this comment.
Här rättar jag mig själv. Skulle ligga i properties som de övriga, men kosmetiskt, fixar nästa gång.
janderssonse
commented
Oct 31, 2025
| public class GenericHashToField implements HashToField { | ||
|
|
||
| protected final byte[] dst; | ||
| @edu.umd.cs.findbugs.annotations.SuppressFBWarnings( |
Contributor
Author
There was a problem hiding this comment.
Spotbugs använder fortfarande findbugs annoationsnamn tll synes, då de vill vara bakåtkompatibla.
janderssonse
commented
Oct 31, 2025
| </rulesets> | ||
| <printFailingErrors>true</printFailingErrors> | ||
| <failOnViolation>true</failOnViolation> | ||
| <linkXRef>false</linkXRef> |
Contributor
Author
There was a problem hiding this comment.
Behövs ej, används bara för att generera pmd docs, och ger då udda varning så därför bort.
janderssonse
commented
Oct 31, 2025
| <consoleOutput>true</consoleOutput> | ||
| <failsOnError>true</failsOnError> | ||
| <violationSeverity>error</violationSeverity> | ||
| <violationSeverity>warning</violationSeverity> |
Contributor
Author
There was a problem hiding this comment.
Ja, nu när vi är rena så kan vi ju prova denna.
jhdigg
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further improves the just + mise ci refactoring
Uses reusable ci 2.1.1
Fixes all remaining checkstyle and spotbugs warnings.
Checklist