Skip to content

Feature/332 dok06#341

Merged
mmjohansson merged 17 commits intomainfrom
feature/332-dok06
Aug 26, 2025
Merged

Feature/332 dok06#341
mmjohansson merged 17 commits intomainfrom
feature/332-dok06

Conversation

@mmjohansson
Copy link
Copy Markdown
Contributor

@mmjohansson mmjohansson commented Jun 17, 2025

Pull Request Description

Fixes #332

Checklist

  • Changes are limited to a single goal (avoid scope creep)
  • I confirm that I have read any Contribution and Development guidelines (CONTRIBUTING and DEVELOPMENT) and are following their suggestions.
  • I confirm that I wrote and/or have the right to submit the contents of my Pull Request, by agreeing to the Developer Certificate of Origin, (adding a 'sign-off' to my commits).

@mmjohansson mmjohansson linked an issue Jun 17, 2025 that may be closed by this pull request
@mmjohansson mmjohansson force-pushed the feature/332-dok06 branch 2 times, most recently from 8b4cd1e to 905f75a Compare June 17, 2025 09:20
Copy link
Copy Markdown
Collaborator

@fredriknordlander fredriknordlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut i stort 👍
Ngr grejor: I message, så ska vi utelämna själva kravID, dvs DOK.06
Man kan också fundera på ifall man ska komplettera constanterna i de båda listorna med fler ord.

@mmjohansson
Copy link
Copy Markdown
Contributor Author

I message, så ska vi utelämna själva kravID, dvs DOK.06

Det hade jag missat. Fixar det!

Man kan också fundera på ifall man ska komplettera constanterna i de båda listorna med fler ord.

Håller med. Lösningen kommer kanske aldrig vara helt vattentät, men den kan absolut förbättras.

@brorlarsnicklas
Copy link
Copy Markdown
Collaborator

brorlarsnicklas commented Jun 18, 2025

Man kan också fundera på ifall man ska komplettera constanterna i de båda listorna med fler ord.

Kan vara min personliga åsikt men tycker man bör undvika att utgå från ordlistor, och om vi ska utgå från ordlistor bör de vara längre och innehålla fler ord med relevant kontext till api:er.

Alternativa lösningar skulle kunna vara lib eller något som identifierar språk baserat på sträng, undersökte dock ett sådant lib som inte heller gav ett vattentätt resultat.

@mmjohansson mmjohansson marked this pull request as draft June 19, 2025 09:28
@mmjohansson mmjohansson removed the request for review from brorlarsnicklas June 19, 2025 09:46
@mmjohansson mmjohansson force-pushed the feature/332-dok06 branch 2 times, most recently from 222261b to 9520186 Compare August 18, 2025 12:06
@mmjohansson mmjohansson force-pushed the feature/332-dok06 branch 4 times, most recently from 0ce9bd7 to 784ed44 Compare August 20, 2025 10:48
@mmjohansson mmjohansson marked this pull request as ready for review August 20, 2025 10:50
@mmjohansson mmjohansson dismissed fredriknordlander’s stale review August 22, 2025 11:14

Ändringar har kommit in efter att denna review gjordes.

@mmjohansson mmjohansson requested review from mirelle-xlent and removed request for fredriknordlander August 22, 2025 11:29
@mmjohansson mmjohansson removed the request for review from mirelle-xlent August 26, 2025 10:36
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
…ters

Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
Signed-off-by: Mats Johansson <extern.mats.johansson@digg.se>
@mmjohansson mmjohansson merged commit 643dc65 into main Aug 26, 2025
8 checks passed
@mmjohansson mmjohansson removed a link to an issue Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants