Skip to content

fix: add message to report #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirelle-xlent merged 1 commit into from
Mar 4, 2026
Merged

fix: add message to report #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions src/util/RapLPDiagnostic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ class RapLPDiagnostic {
rules: Record<string, any>,
instanceCategoryMap: Map<string, any>,
): void {
this.processRuleExecutionLog(this.context.ruleExecutionLogDictionary, raplpCustomResult, instanceCategoryMap,rules);
this.processRuleExecutionLog(
this.context.ruleExecutionLogDictionary,
raplpCustomResult,
instanceCategoryMap,
rules,
);
}
private processRuleExecutionLog(
log: RuleExecutionLog,
Expand All @@ -33,17 +38,17 @@ class RapLPDiagnostic {
let executedRuleIds = new Set<string>(); // Set to track executed rule IDs
let executedRuleIdsWithError = new Set<string>(); // Set to track executed rule IDs with error
let ruleIdsNotApplicable = new Set<string>(); // Set to track rules that are not applicable, that is the (Δ) between the two above sets
const ruleIdToMessage = new Map<string, string>();


for (const key in log) {
const rules = log[key];
const { moduleName, className } = rules[0]; // Get module and class name from the first entry
const execRules = log[key];
const { className } = execRules[0]; // Get module and class name from the first entry
//console.log(`Rule execution status for ${moduleName}:${className}:`);
rules.forEach((rule) => {

execRules.forEach((rule) => {
const { customProperties, severity, passed, targetVal } = rule;
const status = passed ? 'PASSED' : 'FAILED';
const severityText = severity.toUpperCase();
const message = rules[className]?.message ?? ''; // Lookup instance message
// Check if rule is found in Spectral results
const spectralResult = spectralResults.find((result) => {
return result.område === customProperties.område && result.id === customProperties.id;
Expand All @@ -55,8 +60,8 @@ class RapLPDiagnostic {
this._ruleSets.executedUniqueRulesWithError.push({
id: customProperties.id, // Store some more diagnostic info (Duplicate NOT OK)
område: customProperties.område,
krav: rules[key]?.message ?? '',
helpUrl: customProperties.id ? buildRuleHelpUrl(customProperties.id) : undefined,
krav: message,
});
}
}
Expand All @@ -69,8 +74,8 @@ class RapLPDiagnostic {
this._ruleSets.executedUniqueRules.push({
id: customProperties.id, // Store some more diagnostic info (Duplicate OK)
område: customProperties.område,
krav:rules[key]?.message ?? '',
helpUrl: customProperties.id ? buildRuleHelpUrl(customProperties.id) : undefined,
krav: message,
});
}
executedRuleIds.add(customProperties.id); // Store current ID of rule with NO error
Expand All @@ -85,9 +90,9 @@ class RapLPDiagnostic {
});
if (!ruleIdsNotApplicable.has(customProperties.id) && !exists) {
// If not present, store the id and område in the not applicableRules
this._ruleSets.notApplicableRules.push({
id: customProperties.id,
område: customProperties.område,
this._ruleSets.notApplicableRules.push({
id: customProperties.id,
område: customProperties.område,
krav: rules[key]?.message ?? '',
helpUrl: customProperties.id ? buildRuleHelpUrl(customProperties.id) : undefined,
}); // Rules
Expand All @@ -106,7 +111,7 @@ class RapLPDiagnostic {
'N/A',
'Godkända regler - RAP-LP',
),
);
);
}
if (
this.diagnosticInformation.executedUniqueRulesWithError &&
Expand Down Expand Up @@ -171,7 +176,6 @@ interface DiagnosticRuleInfo {
krav: string;
/**Helper Url for guidelines */
helpUrl?: string;

}
interface PopulatedDiagnosticRuleInfo extends DiagnosticRuleInfo {
status: string;
Expand Down