Merged
Conversation
Member
Author
|
Seeing this warning on windows runs: (node:1492) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.Issue upstream was addressed but hasn't been released, it seems. |
achou11
added a commit
that referenced
this pull request
Jan 26, 2026
Lays the groundwork for being able to run e2e tests in isolation from one another, which enables the following: 1. Being able to run the tests in parallel. Before, there was a specific sequence that needed to occur between tests because of the use of outputs between test projects. Now each test runs with its own data directory so there's no sharing of outputs. 2. Being able to "parameterize" tests such that we can test various scenarios for a given flow. The old test setup was pretty limited in that we were essentially testing a very specific flow (e.g. single player project creator) and if we wanted to test a different flow, it would require a pretty hard to manage implementation. The isolation allows us to write tests that set up their own unique environment/situation. Notable implementation details: - All e2e tests are run in parallel. When running locally, we allow Playwright to attempt to use as many CPU cores as are available. In CI we limit it to 3 max, which is based on the [specs of the GitHub Actions runners](https://docs.github.com/en/actions/how-tos/write-workflows/choose-where-workflows-run/choose-the-runner-for-a-job#standard-github-hosted-runners-for-public-repositories). - Each test runs an instance of the application that uses its own user data directory, which provides data isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lays the groundwork for being able to run e2e tests in isolation from one another, which enables the following:
Being able to run the tests in parallel. Before, there was a specific sequence that needed to occur between tests because of the use of outputs between test projects. Now each test runs with its own data directory so there's no sharing of outputs.
Being able to "parameterize" tests such that we can test various scenarios for a given flow. The old test setup was pretty limited in that we were essentially testing a very specific flow (e.g. single player project creator) and if we wanted to test a different flow, it would require a pretty hard to manage implementation. The isolation allows us to write tests that set up their own unique environment/situation.
Notable implementation details:
All e2e tests are run in parallel. When running locally, we allow Playwright to attempt to use as many CPU cores as are available. In CI we limit it to 3 max, which is based on the specs of the GitHub Actions runners.
Each test runs an instance of the application that uses its own user data directory, which provides data isolation.