Conversation
- Add isUrlExpiringSoon utility to imageReplacer.ts - Add validation and retry logic to cacheLoaders.ts for blocks and markdown - Add recursive URL traversal for efficient validation - Add unit tests for expiration logic and traversal
Simplifies wrangler.toml by removing env.production and env.staging sections that referenced non-existent projects. The deployment uses a single project (comapeo-docs) with branch-based environments via --branch flag in GitHub workflows. Also updates compatibility_date to current date.
Contributor
🚀 Preview DeploymentYour documentation preview is ready! Preview URL: https://pr-116.comapeo-docs.pages.dev 🔄 Content: Regenerated 5 pages from Notion (script changes detected)
This preview will update automatically when you push new commits to this PR. Built with commit 7faaf9b |
Contributor
🧹 Preview Deployment CleanupThe preview deployment for this PR has been cleaned up. Preview URL was: Note: Cloudflare Pages deployments follow automatic retention policies. Old previews are cleaned up automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Fix to detect and handle expiring S3 URLs in fresh content fetched from Notion.
Changes
URL Expiration Check (imageReplacer.ts)
isUrlExpiringSoon(url, thresholdSeconds)utilityValidation & Retry in Cache Loaders (cacheLoaders.ts)
loadWithCacheto accept avalidateResultfunctionloadBlocksForPage: checking blocks JSON for expiring URLsloadMarkdownForPage: checking markdown string for expiring URLsUnit Tests
scripts/notion-fetch/__tests__/urlExpiration.test.tsto verify expiration logicVerification Results