Update to LF1.17, Support external daml-sdk tarball#1246
Open
samuel-williams-da wants to merge 6 commits intomainfrom
Open
Update to LF1.17, Support external daml-sdk tarball#1246samuel-williams-da wants to merge 6 commits intomainfrom
samuel-williams-da wants to merge 6 commits intomainfrom
Conversation
Collaborator
Author
|
Note that the upgrade to |
|
@samuel-williams-da is this PR still valid? or stale and can be closed? |
Collaborator
Author
|
I occassionally point people here for how to use a 0.0.0 daml with finance, ideally the 1.17 part should be dropped, and the tar logic should be updated and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an external daml-sdk tarball (i.e. generated by the daml repo as 0.0.0), via an optional field in the root daml.yaml
It also updates every package to LF1.17, enables the correct flags, and moves to daml-script-beta.
This work has uncovered a bug in daml-script and daml-script-beta, which were fixed by this daml pr
This PR uses a snapshot that includes that fix.