Use multi package build#1287
Open
matteolimberto-da wants to merge 45 commits intokaren/daml-3.x-upgradefrom
Open
Use multi package build#1287matteolimberto-da wants to merge 45 commits intokaren/daml-3.x-upgradefrom
matteolimberto-da wants to merge 45 commits intokaren/daml-3.x-upgradefrom
Conversation
…-multi-package-build
Collaborator
|
Thanks @matteolimberto-da for looking at this. I'll provide a review when the CI/scripts/etc are updated. |
Contributor
Author
Thanks! I'll merge this commit as-is into Karen's branch in order to make her life easier when it comes to building packages. Will then modify CI / scripts on a separate branch. Basically my idea is
Easier said then done :) |
Collaborator
|
Removed symlinks and adopted multi-package build across daml-finance.
Next steps (separate PR):
|
…s and integrate daml-ctl v4.0.0; SDK 3.4.9
…s and integrate daml-ctl v4.0.0; SDK 3.4.9
|
Please remove The presence of both in the same scope leads to confusion / unexpected behaviour |
e98ded2 to
16e69ad
Compare
…, dpm, multi-package
…, dpm, multi-package
markus-da
reviewed
Feb 5, 2026
...test/daml/Daml.Finance.Holding.Test/daml/Daml/Finance/Holding/Test/TransferableFungible.daml
Show resolved
Hide resolved
src/test/daml/Daml/Finance/Instrument/Bond/Test/FloatingRate.daml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
multi-package.yamlfile. This means you can calldaml buildon a single package and it will take care of building all dependencies for you.I'll merge it after you've upgraded to the latest
3.4.7SDK.Still a bit of work to do to fix CI, as a bunch of scripts will need to be modified, but overall the setup will be way simpler.