Java bindings ValueDecoder allows decoding values with extra fields #27406 #22751
Open
Viktor-Kalashnykov-da wants to merge 14 commits intomainfrom
Open
Java bindings ValueDecoder allows decoding values with extra fields #27406 #22751Viktor-Kalashnykov-da wants to merge 14 commits intomainfrom
Viktor-Kalashnykov-da wants to merge 14 commits intomainfrom
Conversation
…27406 - codegen First changes
…27406 - codegen More fixes for ValueDecoder and added overriden method for fromJson()
…27406 - codegen More fixes for ValueDecoder and added overriden method for fromJson()
Viktor-Kalashnykov-da
requested review from
adrien-piquerez-da,
jarekr-da and
tudor-da
…27406 - codegen Choice and COMPANION implementation extension for Template
…27406 - codegen Choice and COMPANION implementation extension for Template
…27406 - codegen Choice and COMPANION implementation fixes
…27406 - codegen Choice and COMPANION implementation fixes
…27406 - codegen Tests
…27406 - codegen Tests
…27406 - codegen Tests
…27406 - codegen Refactoring
# Conflicts: # sdk/canton/canton_version.bzl
…27406 - codegen Fixed RecordTest and ListTest
…27406 - codegen Fixed RecordTest and ListTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide overloaded decode() method for GRPC and JSON API that takes the additional 'policy' parameter which instructs Decoder to either throw an error during parsing of DAML Record with additional trailing fields (not known to the Client) into Record class (if STRICT value is provided for policy) or ignore the empty optional trailing fields (if IGNORE value is provided for policy parameter). The default decode() method (that does not take policy parameter) should use STRICT value for the policy by default