extract lf version json from daml-lf-language jar#22773
Open
roger-bosman-da wants to merge 7 commits intomainfrom
Open
extract lf version json from daml-lf-language jar#22773roger-bosman-da wants to merge 7 commits intomainfrom
roger-bosman-da wants to merge 7 commits intomainfrom
Conversation
roger-bosman-da
requested review from
carlpulley-da,
dylant-da and
remyhaemmerle-da
as code owners
Contributor
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Looks like it doesn't work because daml-lf.bzl is trying to load the deleted json file. I'm not sure you can easily adapt it to read the output of a genrule. |
roger-bosman-da
force-pushed
the
roger/extract-versionjson-from-jar
branch
from
d3b9456 to
d01d847
Compare
roger-bosman-da
force-pushed
the
roger/extract-versionjson-from-jar
branch
from
d01d847 to
63914c7
Compare
roger-bosman-da
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.