Skip to content

Working Add Data - Integrate assign entities#94

Merged
pooleycodes merged 12 commits intomainfrom
integrate-assign-entries
Feb 3, 2026
Merged

Working Add Data - Integrate assign entities#94
pooleycodes merged 12 commits intomainfrom
integrate-assign-entries

Conversation

@pooleycodes
Copy link
Copy Markdown
Contributor

@pooleycodes pooleycodes commented Feb 2, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Somewhat still a work in progress, but in the sprint to get to config manager version 1 going the async add data needed a rewrite.

  • The core implementations/changes here are the use of pipeline transform and assign entities function such to correctly check for found entities and assign new lookups for unrecognised transform rows.
  • Some refactoring such as moving source csv and endpoint csv creation to a utils and created in the workflow.py. The pipeline.py file should only be concerned with all the steps to actually run the pipeline.

Related Tickets & Documents

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: Tests do exist for all of these services, more thorough tests of the add data task is definitely needed.
  • I need help with writing tests

[optional] Are there any dependencies on other PRs or Work?

  1. More of an investigation is needed why the check tool has assign_entries() function, is it needed?
  2. Config Manager tests are needed, especially integration tests, some publish examples have been created that would be good to use.

@pooleycodes pooleycodes changed the title Integrate assign entries Working Add Data - Integrate assign entries Feb 3, 2026
@pooleycodes pooleycodes changed the title Working Add Data - Integrate assign entries Working Add Data - Integrate assign entities Feb 3, 2026
@pooleycodes pooleycodes marked this pull request as ready for review February 3, 2026 12:52
@pooleycodes pooleycodes merged commit 7937834 into main Feb 3, 2026
7 checks passed
@Ben-Hodgkiss Ben-Hodgkiss deleted the integrate-assign-entries branch March 3, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants