adds incremental override and resource folder to state.json#358
Merged
CarlosCoelhoSL merged 4 commits intomainfrom Mar 5, 2025
Merged
adds incremental override and resource folder to state.json#358CarlosCoelhoSL merged 4 commits intomainfrom
CarlosCoelhoSL merged 4 commits intomainfrom
Conversation
8 tasks
| compare.pop("incremental_override") | ||
|
|
||
| if current == compare: | ||
| # if current override = false and compare override = true we need to update state.json on s3 but we don't need to process everything |
Contributor
There was a problem hiding this comment.
Aren't we updating the state.json file here? If incremental_override changes from 'True' to 'False' (and everything else stays the same) we would also need the state.json file to incorporate this too.
Contributor
alexglasertpx
left a comment
alexglasertpx
left a comment
There was a problem hiding this comment.
Still not sure we've resolved the issue of when incremental_override is 'True' one day, then the next day it is 'False' and everything else stays the same.
alexglasertpx
approved these changes
Mar 5, 2025
CarlosCoelhoSL
deleted the
add-incremental-loading-override-to-state-json
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Please replace this line with a brief description of the changes made.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?