Merged
Conversation
Contributor
CarlosCoelhoSL
left a comment
CarlosCoelhoSL
left a comment
There was a problem hiding this comment.
lgtm just one small comment
Comment on lines
+517
to
+519
| table_name = os.path.basename( | ||
| os.path.dirname(input_paths[0]) | ||
| ) # Find way to set this in a less hacky way |
Contributor
There was a problem hiding this comment.
is table_name just the dataset? I can't tell but if that's what it's meant to be then it's passed in to the function so you can just use that
CarlosCoelhoSL
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add a 'dataset_update
function to be used instead ofdataset_create` when incremental loading of new resources is implemented.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included