Skip to content

Conversation

@tminard
Copy link
Contributor

@tminard tminard commented Oct 14, 2025

Marked as breaking change as impact on existing services relying on existing behavior is unknown.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.67%. Comparing base (58ca344) to head (9a72abf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   95.67%   95.67%   -0.01%     
==========================================
  Files          10       10              
  Lines         856      855       -1     
==========================================
- Hits          819      818       -1     
  Misses         37       37              
Files with missing lines Coverage Δ
lib/helpers.js 100.00% <100.00%> (ø)
lib/http.js 95.43% <100.00%> (ø)
lib/middleware.js 97.34% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ca344...9a72abf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tminard tminard changed the title Use server.host over req.host when computing keystoreId. Use server.baseUri instead of req.host when computing keystoreId. Oct 14, 2025
@tminard tminard requested a review from dlongley October 14, 2025 18:47
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think there is any scenario underwhich a deployment could be working properly without having set config.server.baseUri properly to begin with -- as this is used in some many other places. But we should confirm with any special deployments before merging and releasing as a minor change.

@tminard tminard merged commit 26d6957 into main Oct 14, 2025
5 checks passed
@tminard tminard deleted the tminard/config-fix branch October 14, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants