Skip to content

Conversation

@jameseaster
Copy link
Contributor

Resolves - add get all keystores route


What kind of change does this PR introduce?

  • new api route

What is the current behavior?

  • no route available for fetching all keystores with root controller

What is the new behavior?

  • added route for fetching all keystores with root controller

Does this PR introduce a breaking change?

  • no

How has this been tested?

  • locally, via symlink

Screenshots:

  • n/a

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 53.62319% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.50%. Comparing base (030def1) to head (3b20442).

Files with missing lines Patch % Lines
lib/BedrockKeystoreConfigStorage.js 8.33% 22 Missing ⚠️
lib/http.js 70.58% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   95.67%   92.50%   -3.18%     
==========================================
  Files          10       10              
  Lines         855      920      +65     
==========================================
+ Hits          818      851      +33     
- Misses         37       69      +32     
Files with missing lines Coverage Δ
schemas/bedrock-kms-http.js 100.00% <100.00%> (ø)
lib/http.js 92.49% <70.58%> (-2.95%) ⬇️
lib/BedrockKeystoreConfigStorage.js 60.00% <8.33%> (-34.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030def1...3b20442. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jameseaster jameseaster requested a review from dlongley November 21, 2025 19:46
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming the suggestions will go in. Thanks!

@jameseaster jameseaster merged commit b394f01 into main Nov 21, 2025
5 checks passed
@jameseaster jameseaster deleted the add-get-all-keystores branch November 21, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants