Skip to content

Add support for strings in acceptedCryptosuites in VPR queries.#101

Merged
dlongley merged 1 commit intomainfrom
accept-string-cryptosuites
Feb 2, 2026
Merged

Add support for strings in acceptedCryptosuites in VPR queries.#101
dlongley merged 1 commit intomainfrom
accept-string-cryptosuites

Conversation

@dlongley
Copy link
Copy Markdown
Member

@dlongley dlongley commented Feb 2, 2026

No description provided.

@dlongley dlongley requested a review from bparth24 February 2, 2026 17:00
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.35%. Comparing base (fa3a549) to head (54db9ea).

Files with missing lines Patch % Lines
lib/exchanges/util.js 0.00% 20 Missing ⚠️
lib/presentations.js 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   16.52%   16.35%   -0.17%     
==========================================
  Files          24       24              
  Lines        1071     1082      +11     
==========================================
  Hits          177      177              
- Misses        894      905      +11     
Files with missing lines Coverage Δ
lib/presentations.js 9.90% <0.00%> (-0.10%) ⬇️
lib/exchanges/util.js 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3a549...54db9ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bparth24 bparth24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlongley

All the changes looks good to me. Though I have not tested by running locally.

@dlongley dlongley merged commit 04795e0 into main Feb 2, 2026
3 checks passed
@dlongley dlongley deleted the accept-string-cryptosuites branch February 2, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants