Skip to content

Remove console.log call.#84

Merged
tminard merged 2 commits intomainfrom
tminard/fix-log-bug
Jan 31, 2025
Merged

Remove console.log call.#84
tminard merged 2 commits intomainfrom
tminard/fix-log-bug

Conversation

@tminard
Copy link
Copy Markdown
Contributor

@tminard tminard commented Jan 31, 2025

Closes #20

@tminard tminard requested a review from dlongley January 31, 2025 21:54
Copy link
Copy Markdown
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine to add the new creationTimeMs to the result ... I wonder if we want to wrap it though so we can add other stats and perhaps more easily fiddle with it in the future. I'll propose that. Thanks!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.88%. Comparing base (faf2103) to head (3d41944).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   10.97%   10.88%   -0.09%     
==========================================
  Files          22       22              
  Lines         993      992       -1     
==========================================
- Hits          109      108       -1     
  Misses        884      884              
Files with missing lines Coverage Δ
lib/helpers.js 33.98% <100.00%> (-0.64%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf2103...3d41944. Read the comment docs.

Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@tminard tminard merged commit 212ac42 into main Jan 31, 2025
3 checks passed
@tminard tminard deleted the tminard/fix-log-bug branch January 31, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove extra console logging.

3 participants