Merged
Conversation
Delegate toNFCPayload and hasNFCPayload to dedicated nfcRenderer.js, supporting both TemplateRenderMethod and legacy NfcRenderingTemplate2024. Continues work from PR #93.
Closed
dlongley
approved these changes
Jan 26, 2026
Member
dlongley
left a comment
There was a problem hiding this comment.
We need a CHANGELOG entry for a minor release that adds bundled nfcRenderer support.
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 10.58% 16.52% +5.94%
==========================================
Files 22 24 +2
Lines 1011 1071 +60
==========================================
+ Hits 107 177 +70
+ Misses 904 894 -10
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces PR#93 - feedback addressed, rebased cleanly on main.
Note: Once this PR is approved and merged - PR#93 should be closed without merging.
Further details on test case results: