Add the most minimal approach available. #3
Conversation
BigBlueHat
force-pushed
the
add-minimal
branch
from
a9c0eb0 to
eff3d84
Compare
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
I think we probably don't want to say this is the most minimal without anything that tells the parent window that the template is ready. Otherwise, LGTM.
|
Maybe this should go in as "without-ready-event.html"? Or something? |
So we need to make the "ready" thing in the shim a MUST then? |
Yeah, I think so. Since there are two independent parties involved here (host and template author), and the host is showing content on behalf of the template author, I think the template author should be required to make a minimal effort to inform the host when their template is ready to at least help ensure both of their reputations aren't harmed by bad flashes of content / renderings, etc. I would expect hosts to want some control over loading screens, timeouts, and whether to show error screens based on slow / bad templates. We might want to consider / make the "ready" callback resolve or reject a promise as well, to allow a template author to reject with an error if they receive a VC that doesn't work for the template (i.e., via a mistake by the host). |
Host page uses CSP meta tag, contains a sandboxed iframe, populates it with a shim-page with another CSP meta tag along with the credential in a datablock and the template as the contents of `<body>`.
BigBlueHat
force-pushed
the
add-minimal
branch
from
b683989 to
2cdfb05
Compare
Host page uses CSP meta tag, contains a sandboxed iframe, populates it
with a shim-page with another CSP meta tag along with the credential
in a datablock and the template as the contents of
<body>.