Skip to content

Miscellaneous changes #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 25, 2020
Merged

Miscellaneous changes #354

merged 12 commits into from
Jan 25, 2020

Conversation

gkellogg
Copy link
Collaborator

@gkellogg gkellogg commented Jan 12, 2020 •
edited by davidlehn
Loading

A bunch of fixes that address everything other than Framing and some toRdf tests.

  • Do minimal checking to see if IRIs are valid by making sure they contain no whitespace.
    (804c15b)
  • Terms of the form of an IRI must map to the same IRI. (280a01e)
  • Terms of the form of a relative IRI may not be used as prefixes. (280a01e)
  • Keep term definitions mapping to null so they may be protected. (2613c4a)
  • Use localLoader for remote tests. (ff95ee2)
  • Support rel=alternate. (080e374)
    • Note XHR and Node loaders don't have their own tests.
  • Always pass typeScopedContext to _expandObject. (f0d80f1)
  • Allow a keyword to exist when expanding in _expandObject when the key is @included or @type. (f0d80f1)

davidlehn
davidlehn reviewed Jan 13, 2020
View reviewed changes
@gkellogg gkellogg requested a review from davidlehn January 14, 2020 21:02
@gkellogg gkellogg mentioned this pull request Jan 14, 2020
Open
@davidlehn davidlehn added this to the JSON-LD 1.1 milestone Jan 17, 2020
gkellogg and others added 12 commits January 25, 2020 16:50
@gkellogg @davidlehn
Do minimal checking to see if IRIs are valid by making sure they cont…
fc414ad 
…ain no whitespace.
@gkellogg @davidlehn
- Terms of the form of an IRI must map to the same IRI.
249b96a 
- Terms of the form of a relative IRI may not be used as prefixes.
@gkellogg @davidlehn
Keep term definitions mapping to null so they may be protected.
0944c3c
@gkellogg @davidlehn
Use localLoader for remote tests.
9e4dacd
@gkellogg @davidlehn
Support rel=alternate.
02aeaef 
Note XHR and Node loaders don't have their own tests.
@gkellogg @davidlehn
- Always pass typeScopedContext to _expandObject.
a92b6df 
- Allow a keyword to exist when expanding in _expandObject when the key is `@included` or `@type`.
@gkellogg @davidlehn
Fix CHANGELOG.
d8fae55
@gkellogg @davidlehn
Renable more passing toRdf tests.
66dc048
@gkellogg @davidlehn
Improve isDouble to look for big integers.
f592014
@gkellogg @davidlehn
URI removeDotSegments only ensures preceding '/' if was already absol…
c5e6487 
…ute.
@davidlehn
Fix changelog.
7a5c342
@davidlehn
Keep old deprecated constant.
f0b8bb8 
- Keep in case anyone was using it. Will remove later.
@davidlehn davidlehn merged commit 6891936 into master Jan 25, 2020
@davidlehn davidlehn deleted the misc branch January 25, 2020 22:47
@tpluscode tpluscode mentioned this pull request Feb 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlehn davidlehn davidlehn approved these changes

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JSON-LD 1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @davidlehn @dlongley